27 Nov
2025
27 Nov
'25
4:24 p.m.
Jacek Caban (@jacek) commented about dlls/msxml3/node.c:
+ if (FAILED(hr)) + WARN("User script Invoke() failed %#lx, function %s.\n", hr, xpath->function); + + if (args) + { + for (int i = 0; i < nargs; ++i) + VariantClear(&args[i]); + free(args); + } + + switch (V_VT(&result)) + { + case VT_BSTR: + { + xmlChar *s = xmlchar_from_wchar(V_BSTR(&result)); + xmlXPathReturnString(ctxt, s); I think we should use `xmlMalloc` for the string here.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9600#note_123956