Re: [PATCH 0/1] MR3011: wldap32: Clean up LDAP_OPT_API_INFO.

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/wldap32/option.c:
> LDAPAPIInfo infoU;
>          LDAPAPIInfoW *infoW = value;
>
> -        memset( &infoU, 0, sizeof(infoU) );
>          infoU.ldapai_info_version = infoW->ldapai_info_version;
>
> ret = map_error( ldap_get_option( CTX(ld), option, &infoU ) );
> -        if (ret == WLDAP32_LDAP_SUCCESS)
> -        {
> -            infoW->ldapai_api_version = infoU.ldapai_api_version;
> -            infoW->ldapai_protocol_version = infoU.ldapai_protocol_version;
> +        if (ret != LDAP_SUCCESS) return ret;

Please keep WLDAP32_LDAP_SUCCESS. It has the same value as LDAP_SUCCESS but map_error() returns WLDAP32_ prefixed values.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3011#note_35091