Re: [PATCH 0/8] MR5881: d3dx9: Use shared code for loading volumes/volume textures from files.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/texture.c:
> +                const uint32_t *expected_color = &bmp_32bpp_4_4_argb_expected[(y < (desc.Height / 2)) ? 0 : 2];
>
> -                    for (x = 0; x < desc.Width; ++x)
> -                    {
> -                        if (x < (desc.Width / 2))
> -                            check_volume_readback_pixel_4bpp(&volume_rb, x, y, z, expected_color[0], FALSE);
> -                        else
> -                            check_volume_readback_pixel_4bpp(&volume_rb, x, y, z, expected_color[1], FALSE);
> -                    }
> +                for (x = 0; x < desc.Width; ++x)
> +                {
> +                    if (x < (desc.Width / 2))
> +                        check_volume_readback_pixel_4bpp(&volume_rb, x, y, z, expected_color[0], todo);
> +                    else
> +                        check_volume_readback_pixel_4bpp(&volume_rb, x, y, z, expected_color[1], todo);
>                  }
> We might want to use `winetest_push_context()` / `winetest_pop_context()` to trace the mip level here.

No need to go around adding context to all the old tests but worth considering for tests to come.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5881#note_74668