Re: [PATCH 0/3] MR3737: winegstreamer: Implement wg_muxer.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/unixlib.c:
> !gst_element_sync_state_with_parent(element) ||
> -            (*last && !gst_element_link(*last, element)))
> +            (last && *last && !gst_element_link(*last, element)))
>      {
>          GST_ERROR("Failed to link %s element.", name);
>      }
>      else
>      {
>          GST_DEBUG("Linked %s element %p.", name, element);
> -        if (!*first)
> +        if (first && !*first)
>              *first = element;
> +        if (last)
>              *last = element;
>          success = true;
>      }

I'd prefer not allowing NULL, this will avoid mistakes breaking the list, in case of mismatched NULL / non-NULL calls.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3737#note_44528