20 Jul
2023
20 Jul
'23
11:01 a.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
token = *(*ptr)++;
register_type = (token & VKD3D_SM4_REGISTER_TYPE_MASK) >> VKD3D_SM4_REGISTER_TYPE_SHIFT; - if (register_type >= ARRAY_SIZE(register_type_table) - || register_type_table[register_type] == VKD3DSPR_INVALID) + register_type_info = get_register_type_info(register_type); + if (!register_type_info || register_type_info->handler_type == VKD3DSPR_INVALID)
If a valid `register_type_info` is returned, then it never has `VKD3DSPR_INVALID`, I think? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/281#note_39588