Rémi Bernon (@rbernon) commented about dlls/dmsynth/synth.c:
UINT gen;
if (conn->usControl != CONN_SRC_NONE) return FALSE; - if (conn->usTransform != CONN_TRN_NONE) return FALSE; + if (conn->usTransform != CONN_TRN_NONE + && (conn->usTransform != CONN_TRANSFORM(CONN_TRN_BIPOLAR, CONN_TRN_NONE, CONN_TRN_NONE) + || (conn->usSource != CONN_SRC_LFO && conn->usSource != CONN_SRC_VIBRATO))) + return FALSE;
Can we split these conditions or align them differently so the operator precedence gets readable? ```suggestion:-4+0 if (conn->usTransform != CONN_TRN_NONE) { if (conn->usTransform != CONN_TRANSFORM(CONN_TRN_BIPOLAR, CONN_TRN_NONE, CONN_TRN_NONE)) return FALSE; if (conn->usSource != CONN_SRC_LFO && conn->usSource != CONN_SRC_VIBRATO) return FALSE; } ``` For instance. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9522#note_122916