20 Sep
2024
20 Sep
'24
9:10 p.m.
Rémi Bernon (@rbernon) commented about dlls/bluetoothapis/tests/sdp.c:
+} + +static void test_BluetoothSdpGetElementData_str( void ) +{ + static struct { + BYTE stream[11]; + SIZE_T size; + DWORD error; + SDP_ELEMENT_DATA data; + const char *string; + } test_cases[] = { + { + {SDP_TYPEDISC_STR8, 0x06, 'f', 'o', 'o', 'b', 'a', 'r'}, + 8, + ERROR_SUCCESS, + {SDP_TYPE_STRING, SDP_ST_NONE, .data = {.string = {&test_cases[0].stream[2], 6}}}, Nit: I find the mix of designated initializers / non-designated a bit weird, `.data =` doesn't seem useful?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6402#note_82795