20 Jul
2023
20 Jul
'23
1:58 p.m.
On Thu Jul 20 13:16:32 2023 +0000, Jacek Caban wrote:
Yeah, it is a compiler bug, but changing the code to look like this does not seem like a bad idea: ``` if (!(weakmap = get_weakmap_this(ctx, vthis)) return DISP_E_EXCEPTION; ``` That would complicate the case with JS_E_OBJECT_EXPECTED and also it would be different than for Map or Set. :/
Probably better if I just return DISP_E_EXCEPTION from it instead of throw_error's return value, since it's the same anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3300#note_39615