22 May
2023
22 May
'23
1:33 p.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
} }
+/* Create a new extern variable for each object component within each extern variable. */ +static void promote_object_components_to_variables(struct hlsl_ctx *ctx, struct hlsl_ir_function_decl *entry_func)
I guess that with this pass the `hlsl_fixme()`'s in `write_sm4_resource_load()` and `write_sm4_resource_store()` can be promoted to `assert()`'s? Also, but very minor: I don't feel the verb "promote" is really appropriate here. To me "promotion" usually means we're somehow playing with types, but no type is involved here. Maybe "split" would be more appropriate? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/209#note_33386