Re: [PATCH 0/1] MR1054: gdi32: Prevent out of bounds array access

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/gdi32/uniscribe/shape.c:
> /* Do not allow justification between marks and their base */
>      for (i = 0; i < cGlyphs; i++)
>      {
> -        if (!pGlyphProp[i].sva.fClusterStart)
> +        if (!pGlyphProp[i].sva.fClusterStart && (i-dirL) >= 0)
>              pGlyphProp[i-dirL].sva.uJustification = SCRIPT_JUSTIFY_NONE;

I think it's more concerning that pGlyphProp[i].sva.fClusterStart is 0 for i == 0, assuming that's a case this is meant to catch.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1054#note_10569