Re: [PATCH v6 0/3] MR1199: xmllite/writer : Implement a few APIs

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/xmllite/writer.c:
> return MX_E_ENCODING;
>      case XmlWriterState_DocClosed:
>          return WR_E_INVALIDACTION;
> +    case XmlWriterState_Ready:
> +        write_xmldecl(writer, XmlStandalone_Omit);
> +	break;
> +    case XmlWriterState_ElemStarted:
> +	writer_close_starttag(writer);

This is mixing tabs and spaces. More importantly, it does not look tested. If I remove write_xmldecl() here, I don't get any test failures.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1199#note_17597