Re: [PATCH v4 0/1] MR7052: vbscript: implement Join()

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/vbscript/global.c:
> +            return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE);
> +        if(V_VT(args+1) != VT_BSTR)
> +        {
> +            hres = to_string(args+1, &delimiter);
> +            if(FAILED(hres)) {
> +                return hres;
> +            }
> +        }
> +        else
> +            delimiter = V_BSTR(args+1);
> +    }
> +    else
> +        delimiter = SysAllocString(L" ");
> +
> +    if (SafeArrayGetDim(sa) != 1)
> +        return E_NOTIMPL;
> It's fine to skip this, but unless native returns E_NOTIMPL as well, please add a `FIXME` message.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7052#note_91499