Re: [PATCH v8 0/5] MR8723: cfgmgr32: device query part 3: Add support for basic filter expressions.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/cfgmgr32/main.c:
> +    const DEVPROPERTY *cmp_prop = &filter->Property;
> +    DEVPROP_OPERATOR op = filter->Operator;
> +    const DEVPROPERTY *prop = NULL;
> +    BOOL ret = FALSE;
> +    HRESULT hr;
> +
> +    TRACE( "(%p, %s)\n", ctx, debugstr_DEVPROP_FILTER_EXPRESSION( filter ) );
> +
> +    if ((op & DEVPROP_OPERATOR_MASK_MODIFIER) & ~(DEVPROP_OPERATOR_MODIFIER_NOT | DEVPROP_OPERATOR_MODIFIER_IGNORE_CASE))
> +        return E_INVALIDARG;
> +
> +    switch (filter->Operator & DEVPROP_OPERATOR_MASK_EVAL)
> +    {
> +    case DEVPROP_OPERATOR_EXISTS:
> +        hr = devprop_filter_context_find_prop( ctx, &filter->Property.CompKey, &prop );
> +        if (FAILED(  hr ))
        if (FAILED( hr ))

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8723#note_112334