2 Jun
2023
2 Jun
'23
1:14 p.m.
Jacek Caban (@jacek) commented about dlls/jscript/compile.c:
HRESULT hres;
if(is_memberid_expr(expr->expression->type)) { - op = OP_call_member; + if(expr->expression->type == EXPR_IDENT && !wcscmp(((identifier_expression_t*)expr->expression)->identifier, L"eval")) + op = OP_call_member_eval;
I think it would be cleaner to have something like `OP_call_eval`, which knows the identifier anyway, and skip `compile_memberid_expression` entirely in this case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2942#note_34444