15 Nov
2023
15 Nov
'23
2:46 p.m.
Recent change to make unixlibs use hidden visibility made DECLSPEC_EXPORT being used in more cases. This means that it's used for PE modules as well, which is meant to be ignored since we use .spec files and winebuild-generated .edata anyway. This has some side effects: - LLD correctly ignores dllexport when it detects .edata presence, but it also issues a warning: `lld-link: warning: literal .edata sections override exports` - AFAIR (I didn't verify), GNU LD would still generate its own .edata entries, but the one provided by winebuild will be actually used by PE header - non-mingw builds will use default visibility for those symbols in PE modules -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4401