31 Jul
2025
31 Jul
'25
9:02 a.m.
On Thu Jul 31 10:41:23 2025 +0000, Rémi Bernon wrote:
The state machine should guarantee that `impl->query` is set here. What about enforcing `DevCloseObjectQuery called && query == NULL` as an invariant everywhere, like this instead: ```suggestion:-1+0 DevCloseObjectQuery( impl->query ); impl->query = NULL; ``` And remove the corresponding `watcher->query = NULL` above on `DevQueryStateClosed`. Yeah, that's cleaner. Thanks.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8555#note_111668