Re: [PATCH v38 0/6] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/wintypes/tests/propertyset.c:
> +        return;
> +    }
> +
> +    hr = IInspectable_QueryInterface( inspectable, &IID_IPropertySet, (void **)&propset );
> +    IInspectable_Release( inspectable );
> +    todo_wine ok( SUCCEEDED( hr ), "QueryInterface failed, got %#lx\n", hr );
> +    if (FAILED( hr ))
> +    {
> +        RoUninitialize();
> +        return;
> +    }
> +
> +    hr = IPropertySet_QueryInterface( propset, &IID_IMap_HSTRING_IInspectable, (void **)&map );
> +    todo_wine ok( SUCCEEDED( hr ), "QueryInterface failed, got %#lx\n", hr );
> +    if (FAILED( hr ))
> +    {
> Leaking propset here. And you might want to use a "goto done;" to simplify failure handling.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6766#note_89007