18 Dec
2022
18 Dec
'22
11:32 p.m.
Zebediah Figura (@zfigura) commented about dlls/kernelbase/path.c:
*/ HRESULT WINAPI UrlFixupW(PCWSTR url, PWSTR translatedUrl, DWORD maxChars) { - DWORD srcLen; + DWORD srcLen, dstLen, len; + DWORD colon_pos = 0, pos = 0; + wchar_t *helper_str = NULL; + PWSTR save_str = translatedUrl; We use WCHAR, not wchar_t.
It'd also be nice to use a consistent style for all of variable names in this function (wrt snake case vs camel case). In new code I think we prefer snake case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19808