28 May
2024
28 May
'24
9:20 p.m.
Huw Davies (@huw) commented about dlls/shell32/shlexec.c:
WCHAR wBuffer[256]; /* Used to GetProfileString */ UINT retval = SE_ERR_NOASSOC; WCHAR *tok; /* token pointer */ - WCHAR xlpFile[256]; /* result of SearchPath */ + WCHAR xlpFile[MAX_PATH]; /* result of SearchPath */
It would be nice (if we are using fixed sized buffers here) that the calls to `GetFullPathNameW()` (and `GetCurrentDirectoryW()`) below used `ARRAY_SIZE()` instead of hard-coding the size. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5692#note_71270