Re: [PATCH v2 0/2] MR3397: Draft: ucrtbase: Do not modify rewind's stack arguments on i386.

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/file.c:
> return 0;
>  }
>
> +#if defined(__i386__)
> +/* INTERNAL: stack preserving thunk for rewind */
> +__ASM_GLOBAL_FUNC(wine_i386_rewind,
> +                  "pushl 4(%esp)\n\t"
> +                  "call "__ASM_NAME("rewind") "\n\t"
> +                  "popl %eax\n\t"
> +                  "ret")
> +#endif
> Please add CFI annotations and remove `INTERNAL: ` prefix from the comment. Since it's added for a broken app I think it's useful to add a short comment saying "needed for ...".

How about changing `wine_i386_rewind` function name to `rewind_preserve_stack`?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3397#note_40128