On Mon Sep 26 14:44:18 2022 +0000, Piotr Caban wrote:
I think it's easy to implement helpers in modules that need it so there's no big profit from adding global header. It also resolves a problem of e.g. using different allocators in different modules and allows optimizing helpers for specific use cases. That's why I think it's better to introduce string helper functions in shell32 if needed. The allocator problem could be solved using defines prior to the header inclusion, but I see that it would get a bit messy to work with. The code duplication will not end, but I suppose that's not my problem. ¯\\\_(ツ)\_/¯
Thank you for your input and having a look at this MR in first place. I will add module-specific functions in that case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/910#note_9273