8 Nov
2022
8 Nov
'22
3:44 p.m.
On Mon Nov 7 23:00:29 2022 +0000, Esme Povirk wrote:
I'm confused why it's not necessary to check the condition if we get a non-NULL node2 here. In `get_sibling_node_for_tree()`, we're not concerned with checking the condition on the sibling, we're only concerned with retrieving it. The sibling returned from `get_sibling_node_for_tree()`, if there is one, gets passed into `traverse_uia_node_tree()` which has its condition checked as it's 'visited'.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1249#note_13719