Re: [PATCH 0/7] MR4234: msvcrt: Add implementation to _mbs*_l and _cwprintf_l functions

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/mbcs.c:
> /*********************************************************************
> - *              _mbslwr(MSVCRT.@)
> + *              _mbslwr_l(MSVCRT.@)
>   */
> -unsigned char* CDECL _mbslwr(unsigned char* s)
> +unsigned char* CDECL _mbslwr_l(unsigned char* s, _locale_t locale)
>  {
> +  pthreadmbcinfo mbcinfo;
>    unsigned char *ret = s;
> -  if (!s)
> +
> +  if (!MSVCRT_CHECK_PMT(s))

The function is not setting errno when s is NULL on Windows.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4234#note_50296