Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c:
> +    if (size_in_bytes & 1) {
> +        sum += *buffer;
> +    }
> +
> +    return (WORD)(HIWORD(sum) + LOWORD(sum));
> +}
> +
> +/* Normalizes a given 32-bit PE image to render a stream that is common. */
> +int normalize_old_file_image(
> +    BYTE *old_file_buffer, ULONG old_file_size,
> +    ULONG option_flags,  PATCH_OPTION_DATA *option_data,
> +    ULONG new_image_base, ULONG new_image_time,
> +    const PATCH_IGNORE_RANGE *ignore_range_array, ULONG ignore_range_count,
> +    const PATCH_RETAIN_RANGE *retain_range_array, ULONG retain_range_count)
> +{
> +    int result = 0;
> You defined symbolic constants; why not use them here?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45762