Re: [PATCH v12 0/4] MR4852: Add support from AudioPathConfig

[Rémi Bernon]

On Thu Jan 18 18:13:17 2024 +0000, Yuxuan Shui wrote:
> No there can be multiple `pchannel_to_buffer`s added to the list here.
> `pchannel_to_buffer == NULL` is the expected condition when the function returns.
> Okay. In that case I would have split the element parsing in a separate helper, which would also let you return errors directly instead of this IMO mildly ugly error setting pattern (because of the waste of vertical space):

```
if (x)
{
    hr = E_FAIL;
    break;
}
```

vs

```
if (x) return E_FAIL;
```

Feel free to change it if you feel like it's a good idea, I've probably nitpicked more than enough here :). Thanks for your patience.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4852#note_57987