Re: [PATCH v2 0/5] MR53: vkd3d-shader/hlsl: transpose(), smoothstep(), and properly convert args of element-wise intrinsics.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.y:
> return NULL;
>
> if (!(x_arg = add_implicit_conversion(ctx, params->instrs, x_arg, common_type, loc)))
>          return NULL;

Shouldn't you remove this part now? `elementwise_intrinsic_convert_args()` should have already taken care of everything, or am I missing something?

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/53#note_19503