Re: [PATCH v8 0/5] MR8564: cfgmgr32: Device query API part 3: Implement DevGetObjectProperties(Ex) and HDEVQUERY device updates.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/cfgmgr32/main.c:
> +    if (!id || !!props_len != !!props || !!params_len != !!params
> +        || (props_len && (flags & DevQueryFlagAllProperties)))
> +        return E_INVALIDARG;
> +
> +    switch (type)
> +    {
> +    case DevObjectTypeDeviceInterface:
> +    case DevObjectTypeDeviceInterfaceDisplay:
> +    {
> +        SP_DEVICE_INTERFACE_DATA iface = {0};
> +        DEV_OBJECT obj = {0};
> +        HDEVINFO set;
> +
> +        set = SetupDiCreateDeviceInfoListExW( NULL, NULL, NULL, NULL );
> +        if (set == INVALID_HANDLE_VALUE) return HRESULT_FROM_WIN32( GetLastError() );
> +        iface.cbSize = sizeof( iface );
> You could initialize the field directly with the variable above.

```suggestion:-6+0
        SP_DEVICE_INTERFACE_DATA iface = {.cbSize = sizeof( iface )};
        DEV_OBJECT obj = {0};
        HDEVINFO set;

        set = SetupDiCreateDeviceInfoListExW( NULL, NULL, NULL, NULL );
        if (set == INVALID_HANDLE_VALUE) return HRESULT_FROM_WIN32( GetLastError() );
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8564#note_111440