17 Sep
2024
17 Sep
'24
7:40 a.m.
Rémi Bernon (@rbernon) commented about programs/explorer/systray.c:
} nid.hIcon = CreateIcon(NULL, data->icon_info.width, data->icon_info.height, data->icon_info.planes, data->icon_info.bpp, &icon_data[0], &icon_data[cbMaskBits]); + icon_data = &icon_data[cbMaskBits + cbColourBits]; }
+ if ((nid.uFlags & NIF_INFO) && (nid.dwInfoFlags & NIIF_USER) && cds->cbData > ((char*)icon_data - (char*)data))
```suggestion:-0+0 if ((nid.uFlags & NIF_INFO) && (nid.dwInfoFlags & NIIF_USER) && cds->cbData > sizeof(*data)) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2875#note_82360