31 Jul
2023
31 Jul
'23
6:37 a.m.
Huw Davies (@huw) commented about dlls/mmdevapi/devenum.c:
PROPVARIANT pv; + char *dev_name; + unsigned int size = 0; + + TRACE("%s, (%s,%lu)\n", wine_dbgstr_guid(id), wine_dbgstr_guid(&prop->fmtid), prop->pid);
- if (!drvs.pGetPropValue) - return E_NOTIMPL; + if (!drvs.pget_device_name_from_guid(id, &dev_name, ¶ms.flow)) + return E_FAIL;
- hr = drvs.pGetPropValue(id, prop, &pv); + params.device = dev_name; + params.guid = id; + params.prop = prop; + params.result = E_NOTIMPL;
It would be cleaner to add stub `get_prop_value()` implementations to the drivers that don't currently have it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3457#note_40718