The same question can apply to the winebus side, but CRC32 doesn't seem like a very good hashing method? Could we use something a bit more robust or does it not matter for some reason?
Yeah, I was going to use another non-crypt hashing algorithm, but decided to see some comparison results, and surprisingly for 32bit hashes CRC32 was doing very well - one of the fastest with comparable collision rate to the others. I think using two 32bit hashes significantly reduces the chance of collisions here. I could use SHA-1 for a 64bit+ hash if needed. @cmcadams Yes, implementing MediaProperties registry would be ideal. I think some games still rely on it to recognize the capabilities of FFB devices for example. I used the device_id and instance_id from the device_path to generate two crc32 hashes. Since these include vid, pid, version, SN, bus_num, port_num, etc., I think this is sufficient to generate unique guid that serves the purpose. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9687#note_124985