Re: [PATCH 0/1] MR5599: msvcrt/tests: Add tests for _wcsicmp_l.

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/tests/locale.c:
> +        { L"i", L"i",  0 },
> +        { L"I", L"i",  0 },
> +        { L"I", L"i",  0, "Turkish" },
> +        { L"i", L"a",  8 },
> +        { L"a", L"i", -8 },
> +        { L"i", L"a",  8, "Turkish" },
> +    };
> +    int ret, i;
> +
> +    for(i=0; i<ARRAY_SIZE(tests); i++) {
> +        _locale_t loc = NULL;
> +
> +        if(tests[i].loc) {
> +            loc = _create_locale(LC_ALL, tests[i].loc);
> +            ok(!!loc, "Skipping test with %s locale\n", tests[i].loc);
> +            if(!loc) continue;
> The test should never fail so `if(!loc) continue;` is not needed or `win_skip` should be used.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5599#note_69885