Re: [PATCH v7 0/6] MR576: win32u: Move display placement logic out of graphics drivers.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/win32u/sysparams.c:
> +static DEVMODEW *get_display_settings( const WCHAR *devname, const DEVMODEW *devmode )
> +{
> +    DEVMODEW *mode, *displays;
> +    struct adapter *adapter;
> +    BOOL ret;
> +
> +    if (!lock_display_devices()) return NULL;
> +
> +    /* allocate an extra mode for easier iteration */
> +    if (!(displays = calloc( list_count( &adapters ) + 1, sizeof(DEVMODEW) ))) goto done;
> +    mode = displays;
> +
> +    LIST_FOR_EACH_ENTRY( adapter, &adapters, struct adapter, entry )
> +    {
> +        if (!adapter->mode_count) continue;

There should be at least one available mode so this condition seems unnecessary.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/576#note_6224