22 Mar
2024
22 Mar
'24
9:12 p.m.
Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.h:
+/* This struct is used to represent the two main types of state block entries: + * Assignment: + * name = {args[0], args[1], ...}; + * - or - + * name = args[0] + * - or - + * name[lhs_array_size] = args[0] + * - or - + * name[lhs_array_size] = {args[0], args[1], ...}; + * FX function call: + * name(args[0], args[1], ...); + */ +struct hlsl_state_block_entry +{ + bool is_function_call;
This is especially dead code if we aren't even parsing functions yet. And... do we really want to do it this way? Could we store them in a separate array? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/739#note_65842