On Tue Mar 14 21:20:15 2023 +0000, Henri Verbeet wrote:
Pre-existing, and hardly critical, but since we're touching it:
```diff - /* Array lenght, or HLSL_ARRAY_ELEMENTS_COUNT_IMPLICIT if
it is unknown yet while parsing. */
+ /* Array length, or HLSL_ARRAY_ELEMENTS_COUNT_IMPLICIT if it is unknown yet while parsing. */ ``` I'd propose "not known yet", and possibly "at parse time". ```diff - /* Whether the parser is inside an state block (effects' metadata) inside a variable declarition. */ + /* Whether the parser is inside an state block (effects' metadata) inside a variable declaration. */ ``` "a state block" ```diff - /* This redudant load is expected to be deleted later by DCE */ + /* This redundant load is expected to be deleted later by DCE */ ``` Missing punctuation. There are a couple of other instances of this as well. Thanks, I think I changed them all now.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/118#note_26880