Re: [PATCH v5 0/8] MR3810: winegstreamer: Implement add_stream and push_sample for muxer.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/unixlib.c:
> return false;
>      }
> -    if ((ret = gst_pad_link(src_pad, sink_pad)))
> +
> +    return true;
> +}
> +
> +bool link_src_to_element(GstPad *src_pad, GstElement *element)
>  {
> -        gchar *src_name = gst_pad_get_name(src_pad), *sink_name = gst_pad_get_name(sink_pad);
> -        GST_ERROR("Failed to link element pad %s with pad %s", src_name, sink_name);
> -        g_free(sink_name);
> +    GstPad *sink_pad;
> +    bool ret;
> +
> +    if (!(sink_pad = gst_element_get_compatible_pad(element, src_pad, NULL)))

I'd change `gst_element_get_static_pad` to `gst_element_get_compatible_pad` in a separate commit.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3810#note_49875