27 Feb
2026
27 Feb
'26
11:09 a.m.
The changes are looking OK to me but I think it can be simplified by moving `bufsiz` calculation before the loop, I'm thinking about something along these lines: ```c int bufsize = !(file->_flag & (MSVCRT__NOBUF | _IOMYBUF | MSVCRT__USERBUF)) && !msvcrt_alloc_buffer(file) ? 1 : file->_bufsiz; ``` and the if condition in the loop can be changed to: ```c } else if(wrcnt >= bufsiz) { ``` It was not tested so I might be missing something. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10199#note_130704