2 Nov
2023
2 Nov
'23
2:41 p.m.
Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/spirv.c:
spirv_compiler_emit_sincos(compiler, instruction); break; case VKD3DSIH_IMUL: + case VKD3DSIH_UMUL:
That's quite minor, but `spirv_compiler_emit_imul()` has a comment mentioning `SpvOpSMulExtended` explicitly. Maybe you could add `SpvOpUMulExtended` there too, so that the folk eventually implementing it can remember more easily. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/409#note_50642