Re: [PATCH v3 0/7] MR536: xactengine3_7: Add helper function to add entries

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about dlls/xactengine3_7/xact_dll.c:
> return E_OUTOFMEMORY;
>      }
>
> -    lookup = HeapAlloc(GetProcessHeap(), 0, sizeof(*lookup));
> -    if (!lookup)
> +    hr = wrapper_add_entry(This, fwb, &wb->IXACT3WaveBank_iface);
> +    if (FAILED(hr))
>      {
>          FACTWaveBank_Destroy(fwb);
>          HeapFree(GetProcessHeap(), 0, wb);
> -        ERR("Failed to allocate wrapper_lookup!\n");
>          return E_OUTOFMEMORY;

It makes sense to return hr here, maybe?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/536#note_5481