Re: [PATCH v9 0/10] MR4982: Load and play MIDI

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/dmime/midi.c:
> +            if (length > sizeof(event->data.fixed.byte))
> +            {
> +                WARN("Invalid MIDI meta event length %lu for type %#02x\n", length, event->type);
> +                return E_FAIL;
> +            }
> +            hr = stream_read_accumulate(stream, &event->data.fixed.byte[0], length, total_bytes_read);
> +            if (hr == S_OK)
> +            {
> +                if (event->type == MIDI_META_SET_TEMPO)
> +                {
> +                    event->data.integer = (event->data.fixed.byte[0] << 16) |
> +                                          (event->data.fixed.byte[1] << 8) | event->data.fixed.byte[2];
> +                    if (event->data.integer == 0)
> +                    {
> +                        WARN("Invalid tempo value 0\n");
> +                        hr = E_FAIL;
                        return E_FAIL;

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4982#note_60275