Re: [PATCH 0/5] MR7317: Server-side thread priorities implementation (Part 2)

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about server/thread.c:
> THREAD_EXTENDED_POLICY_COUNT );
>      thread_policy_set( thread_port, THREAD_PRECEDENCE_POLICY, (thread_policy_t)&thread_precedence_policy,
>                         THREAD_PRECEDENCE_POLICY_COUNT );
> +    if (base_priority > THREAD_BASE_PRIORITY_LOWRT)
> +    {

I don't really know about macOS, but I don't think implementing realtime priorities is a good idea. At least on Linux I would advise against it (and it needs specific permission anyway). It's IMO putting the system at a higher risk of becoming unresponsive in case of bogus or rogue application.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7317#note_94876