10 Feb
2023
10 Feb
'23
1:13 p.m.
On Fri Feb 10 12:32:25 2023 +0000, Jinoh Kang wrote:
There is no instance of `!~` as an operator sequence in Wine's C codebase. Wine just does `!= ~0` or `!= ~0u` instead. ```suggestion:-0+0 if (ReadNoFence( &group->free_bits ) == ~0) ``` As elsewhere the code is flexible to a different (ie: larger) `free_bits` type I wanted to make sure this doesn't break, as I'm not completely confident about the implicit cast when comparing UINT64 and `~0` / `~0u` for instance.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1628#note_23739