Re: [PATCH v2 0/1] MR2533: wldap32: Implement setting LDAP_OPT_SERVER_CERTIFICATE and add tests.

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/wldap32/bind.c:
> TRACE( "(%p, %s, %p)\n", ld, debugstr_w(dn), passwd );
>
> if (!ld) return WLDAP32_LDAP_PARAM_ERROR;
> +    if (!check_certificate( ld )) return WLDAP32_LDAP_SERVER_DOWN;

Users don't necessarily need to call bind so this check would be needed in any call that requires a server connection.
I think it would be better to implement WLDAP32_ldap_connect() and add the check there. Then you'd call WLDAP32_ldap_connect() in all functions that need a connection. OpenLDAP ldap_connect() doesn't take a timeout but I think we can ignore that for now and just print a fixme.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2533#note_28349