Re: [PATCH v2 0/4] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxbc.c:
> break;
>
> +        case TAG_DXIL:
> +            if (!desc->is_dxil)
> +            {
> +                WARN("Skipping DXIL chunk.\n");
> +                break;
> +            }
> +            /* fall through */
>          case TAG_SHDR:
>          case TAG_SHEX:
> +            if (tag != TAG_DXIL && desc->is_dxil)
> +            {
> +                WARN("Skipping TPF chunk.\n");
> +                break;
> +            }

This feels more complicated than it should be. Maybe just `if (tag == TAG_DXIL != desc->is_dxil) { WARN("Skipping code chunk.\n"); break; }`. I am not even sure we really want a `WARN` here.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44#note_12954