Re: [PATCH v2 0/9] MR6931: win32u: Move surface and swapchain wrappers from winevulkan.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about include/wine/vulkan_driver.h:
> }; \
>      }
>
> +static inline void vulkan_object_init( struct vulkan_object *obj, UINT64 host_handle, struct vulkan_client_object *client )
> +{
> +    obj->host_handle = (UINT_PTR)host_handle;
> +    obj->client_handle = client ? (UINT_PTR)client : (UINT_PTR)obj;
> +    if (client) client->unix_handle = (UINT_PTR)obj;

If you need to condition 2 out of 3 calls in the helper, it seems that having `vulkan_object_init_ptr` separate would be better. If you'd split them, you could just get rid of `client` argument here.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6931#note_89423