8 Nov
2022
8 Nov
'22
1:31 a.m.
Nikolay Sivov (@nsivov) commented about dlls/dwrite/main.c:
}
HRESULT factory_get_cached_fontface(IDWriteFactory7 *iface, IDWriteFontFile * const *font_files, UINT32 index, - DWRITE_FONT_SIMULATIONS simulations, struct list **cached_list, REFIID riid, void **obj) + DWRITE_FONT_SIMULATIONS simulations, const WCHAR *name, struct list **cached_list, REFIID riid, void **obj) Could you explain what you're fixing with this? Cache entries are identified with a file/face index/simulations, names are stored as font data. Why is it necessary to check that, if we are already checking font files for matching. Test case would be great to see.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1291#note_13570