On Sat Dec 13 00:01:26 2025 +0000, Bernhard Übelacker wrote:
Hello @yshui, I am using your patches from this MR when I notice a new version. And I have a CI job running which tries to stay near the regular CI job and uses "--enable-werror". Unfortunately I received now [this error](https://gitlab.winehq.org/bernhardu/wine/-/jobs/217171#L80) : ``` + make -s ../dlls/winecrt0/crt_dllmain.c:37:11: error: '_initterm_e' redeclared without 'dllimport' attribute: previous 'dllimport' ignored [-Werror,-Winconsistent-dllimport] 37 | int CDECL _initterm_e( _PIFV *table, _PIFV *end ); ``` Do you get this first "warning", too? <details> <summary> Unfortunately simply adding the `_ACRTIMP` like used in the declaration makes it fail later with: </summary> ``` tools/winegcc/winegcc -o dlls/kernel32/x86_64-windows/kernel32.dll --wine-objdir . -b x86_64-windows -Wl,--wine-builtin -shared \
/home/bernhard/data/entwicklung/2025/wine/wine/dlls/kernel32/kernel32.spec -nodefaultlibs \ -Wb,-F,KERNEL32.dll -Wl,--image-base,0x178000000 dlls/kernel32/x86_64-windows/atom.o \ dlls/kernel32/x86_64-windows/comm.o dlls/kernel32/x86_64-windows/computername.o \ dlls/kernel32/x86_64-windows/console.o dlls/kernel32/x86_64-windows/debugger.o \ dlls/kernel32/x86_64-windows/file.o dlls/kernel32/x86_64-windows/heap.o \ dlls/kernel32/x86_64-windows/kernel_main.o dlls/kernel32/x86_64-windows/locale.o \ dlls/kernel32/x86_64-windows/lzexpand.o dlls/kernel32/x86_64-windows/module.o \ dlls/kernel32/x86_64-windows/path.o dlls/kernel32/x86_64-windows/powermgnt.o \ dlls/kernel32/x86_64-windows/process.o dlls/kernel32/x86_64-windows/profile.o \ dlls/kernel32/x86_64-windows/resource.o dlls/kernel32/x86_64-windows/sync.o \ dlls/kernel32/x86_64-windows/tape.o dlls/kernel32/x86_64-windows/thread.o \ dlls/kernel32/x86_64-windows/toolhelp.o dlls/kernel32/x86_64-windows/version.o \ dlls/kernel32/x86_64-windows/virtual.o dlls/kernel32/x86_64-windows/volume.o \ dlls/kernel32/version.res -Wl,--debug-file,dlls/kernel32/x86_64-windows/kernel32.pdb \ dlls/kernelbase/x86_64-windows/libkernelbase.a dlls/ntdll/x86_64-windows/libntdll.a \ dlls/winecrt0/x86_64-windows/libwinecrt0.a libs/compiler-rt/x86_64-windows/libcompiler-rt.a \ dlls/winecrtend/x86_64-windows/libwinecrtend.a --no-default-config -fms-hotpatch -Wl,-debug:dwarf lld-link: error: undefined symbol: __declspec(dllimport) _initterm_e
referenced by /home/bernhard/data/entwicklung/2025/wine/wine/dlls/winecrt0/crt_dllmain.c:41 libwinecrt0.a(crt_dllmain.o):(do_global_ctors) NOTE: a relevant symbol '_initterm_e' is available in dlls/winecrtend/x86_64-windows/libwinecrtend.a but cannot be used because it is not an import library.
</summary> I have removed the "--enable-werror" in [this job](https://gitlab.winehq.org/bernhardu/wine/-/jobs/217175#L159), but there I see now also such lines `lld-link: warning: literal .edata sections override exports`, which did not appear with the previous version of this MR.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9265#note_125560