Re: [PATCH v2 0/2] MR208: vkd3d-shader/hlsl: Fix liveness of temps within loops.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_codegen.c:
> LIST_FOR_EACH_ENTRY(instr, &block->instrs, struct hlsl_ir_node, entry)
>      {
> -        const unsigned int var_last_read = loop_last ? max(instr->index, loop_last) : instr->index;
> +        const unsigned int last_read = loop_last ? max(instr->index, loop_last) : instr->index;

That's not really onto this MR, but if `loop_last` is not zero, isn't `max(instr->index, loop_last) == loop_last`, given that we're considering an instruction inside that loop?

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/208#note_32990