8 Feb
2023
8 Feb
'23
12:12 p.m.
Jacek Caban (@jacek) commented about dlls/vbscript/global.c:
V_BSTR(&var) = str;
hres = VariantCopyInd(data+i, &var); + SysFreeString(str);
This is fine for the leak, but it would be even better to avoid extra string copy. We don't really need `VariantCopyInd` in this case, we could just set data[i] variant directly and get rid of var variable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2131#note_23411