24 Feb
2023
24 Feb
'23
5:45 a.m.
Francisco Casas (@fcasas) commented about libs/vkd3d-shader/hlsl.y:
struct hlsl_type *type; unsigned int modifiers = $1;
- if (!(type = apply_type_modifiers(ctx, $2, &modifiers, @1))) + if (!(type = apply_type_modifiers(ctx, $2, &modifiers, true, &@1)))
In the context of the commit is clear, but I think that it would be nice to have a comment to indicate that the sole purpose of this call now is forcing the matrix members of a typedef array to be column-major when no latent majority has been specified. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/102#note_25363