24 Oct
2024
24 Oct
'24
11:36 p.m.
Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/surface.c:
static HRESULT d3dx_image_wic_frame_decode(struct d3dx_image *image, IWICImagingFactory *wic_factory, IWICBitmapFrameDecode *bitmap_frame) { + const GUID *dst_pixel_format = d3dformat_to_wic_guid(image->format); + IWICFormatConverter *wic_converter = NULL; const struct pixel_format_desc *fmt_desc; + IWICBitmapSource *wic_bitmap_src = NULL; + WICPixelFormatGUID src_pixel_format; For the usual nitpick: I guess it would be slightly nicer to consistently use `GUID` (or `WICPixelFormatGUID`, which is a `GUID` `typedef` anyway). Mostly mentioning it because of the `memcmp` below.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6704#note_86020